Preserve StringValue.Encode across string filter transformations - #925
Merged
Conversation
Co-authored-by: sebastienros <1165805+sebastienros@users.noreply.github.com>
sebastienros
marked this pull request as ready for review
February 16, 2026 18:16
Copilot
AI
changed the title
[WIP] Fix string filters to preserve encode state of StringValue
Preserve Feb 16, 2026
StringValue.Encode across string filter transformations
sebastienros
added a commit
that referenced
this pull request
Aug 20, 2026
) * Initial plan * Preserve StringValue encode flag in string filters Co-authored-by: sebastienros <1165805+sebastienros@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: sebastienros <1165805+sebastienros@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ee9c8775-0354-41dd-8226-89a69c60241c
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String filters were dropping
StringValue.Encodewhen producing transformed strings, causing values markedencode: falseto become encoded again (notably inFluid.ViewEnginewithHtmlEncoder). This PR keeps the encode flag when a string filter output is derived from aStringValueinput.Root behavior corrected
StringValue.Encodestate instead of always returning a default-encodedStringValue.Implementation
StringFiltersto create outputs while carrying forwardEncodewheninput is StringValue.StringFiltersto use that helper (e.g.,replace,replace_first,replace_last,append,prepend, casing/trim/strip/newline/truncate variants).Coverage
replacewithHtmlEncoderto verifyencode: falseis retained through transformation.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.