Fix double-encoding when using escape filter with HtmlEncoder - #866
Merged
Conversation
The escape and escape_once filters now return StringValue with Encode=false to prevent double-encoding when rendered with HtmlEncoder. This fixes the issue where captured raw content with escape filter was being double-encoded. Co-authored-by: sebastienros <1165805+sebastienros@users.noreply.github.com>
sebastienros
marked this pull request as ready for review
November 17, 2025 00:48
Copilot
AI
changed the title
[WIP] Fix capturing of encoded liquid tags in HTML
Fix double-encoding when using escape filter with HtmlEncoder
Nov 17, 2025
sebastienros
enabled auto-merge (squash)
November 17, 2025 00:49
sebastienros
added a commit
that referenced
this pull request
Aug 20, 2026
* Initial plan * Fix double-encoding issue with escape filter The escape and escape_once filters now return StringValue with Encode=false to prevent double-encoding when rendered with HtmlEncoder. This fixes the issue where captured raw content with escape filter was being double-encoded. Co-authored-by: sebastienros <1165805+sebastienros@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: sebastienros <1165805+sebastienros@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ee9c8775-0354-41dd-8226-89a69c60241c
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
escapeandescape_oncefilters were causing double-encoding when templates rendered with anHtmlEncoder. Content inside{% capture %}{% raw %}...{% endraw %}{% endcapture %}blocks piped through| escaperesulted in&lt;instead of<.{% capture r %} {% raw %} <ul>item</ul> {% endraw %} {% endcapture %} {{ r | escape }}Previously produced:
&lt;ul&gt;item</ul&gt;(double-encoded)Now produces:
<ul>item</ul>(correctly encoded once)Changes
Core Fix
MiscFilters.EscapeandMiscFilters.EscapeOnceto returnStringValuewithencode: falseHtmlEncoderfrom re-encoding already-escaped content during renderingTests
Encodeproperty is correctly set tofalseThe issue occurred because these filters HTML-encode their input but were returning
StringValueinstances with the defaultEncode = true, causing the renderer'sHtmlEncoderto encode the output again.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.