Skip to content

Detect undefined variables #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 4, 2025
Merged

Detect undefined variables #844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
547a276
#64: Ensure variables completeness with `StrictVariables` option
compyle-bot[bot] Oct 25, 2025
9701599
#64: Replace strict variable buffering with UndefinedValue sentinel
rodion-m Oct 26, 2025
3498f15
Refactor to use Nil
sebastienros Nov 1, 2025
dbc7598
Update documentation
sebastienros Nov 1, 2025
961ae4b
Update variable name
sebastienros Nov 1, 2025
f6ca444
Update Fluid/Values/ObjectValueBase.cs
sebastienros Nov 1, 2025
abc0bf5
Update Fluid.Tests/StrictVariableTests.cs
sebastienros Nov 1, 2025
a6bf0e2
Re-introduce UndefinedValue
sebastienros Nov 1, 2025
81a6d12
Merge branch 'main' into main
sebastienros Nov 4, 2025
878e631
Fix build
sebastienros Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Fluid.Tests/FromStatementTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ Hello world!
await fromStatement.WriteToAsync(sw, HtmlEncoder.Default, context);

Assert.IsType<FunctionValue>(context.GetValue("hello_world"));
Assert.IsType<NilValue>(context.GetValue("hello"));
Assert.IsType<UndefinedValue>(context.GetValue("hello"));
}

[Fact]
Expand Down
6 changes: 3 additions & 3 deletions Fluid.Tests/MiscFiltersTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,7 @@ public async Task JsonShouldWriteNullIfDictionaryNotReturnFluidIndexable()
options.MemberAccessStrategy.Register(model.GetType());
var input = FluidValue.Create(model, options);
var result = await MiscFilters.Json(input, new FilterArguments(), new TemplateContext(options));
Assert.Equal("{\"Id\":1,\"WithoutIndexable\":{\"Type\":5,\"Value\":{}},\"Bool\":true}", result.ToStringValue());
Assert.Equal("{\"Id\":1,\"WithoutIndexable\":{\"Type\":6,\"Value\":{}},\"Bool\":true}", result.ToStringValue());
}

[Fact]
Expand Down Expand Up @@ -910,7 +910,7 @@ public async Task HmacSha1(string key, string value, string expected)
{
// Arrange
FluidValue input = value is null
? NilValue.Empty
? EmptyValue.Instance
: new StringValue(value);
var arguments = new FilterArguments(FluidValue.Create(key, TemplateOptions.Default));
var context = new TemplateContext();
Expand All @@ -932,7 +932,7 @@ public async Task HmacSha256(string key, string value, string expected)
{
// Arrange
FluidValue input = value is null
? NilValue.Empty
? EmptyValue.Instance
: new StringValue(value);
var arguments = new FilterArguments(FluidValue.Create(key, TemplateOptions.Default));
var context = new TemplateContext();
Expand Down
Loading