Skip to content

Obsolete GetValue #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastienros merged 2 commits into from
May 19, 2025
Merged

Obsolete GetValue #796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7386f9
Obsolete GetValue
sebastienros May 5, 2025
d7ee95d
Update Fluid/Values/FluidValue.cs
sebastienros May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Fluid.Tests/Domain/WithInterfaces/PetValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public override ValueTask WriteToAsync(TextWriter writer, TextEncoder encoder, C
throw new NotImplementedException();
}

protected override FluidValue GetValue(string name, TemplateContext context)
public override ValueTask<FluidValue> GetValueAsync(string name, TemplateContext context)
{
if (name == "Name")
{
Expand Down
2 changes: 1 addition & 1 deletion Fluid/Values/ArrayValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public override bool Equals(FluidValue other)
return false;
}

protected override FluidValue GetValue(string name, TemplateContext context)
public override ValueTask<FluidValue> GetValueAsync(string name, TemplateContext context)
{
switch (name)
{
Expand Down
3 changes: 3 additions & 0 deletions Fluid/Values/FluidValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,12 @@ protected static void AssertWriteToParameters(TextWriter writer, TextEncoder enc

public virtual ValueTask<FluidValue> GetValueAsync(string name, TemplateContext context)
{
#pragma warning disable CS0618 // Use obsolete method for backward compatibility
return new ValueTask<FluidValue>(GetValue(name, context));
#pragma warning restore CS0618
}

[Obsolete("This method has been deprecated, please use GetValueAsync() instead.")]
protected virtual FluidValue GetValue(string name, TemplateContext context)
{
return NilValue.Instance;
Expand Down
2 changes: 1 addition & 1 deletion Fluid/Values/StringValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ protected override FluidValue GetIndex(FluidValue index, TemplateContext context
return NilValue.Instance;
}

protected override FluidValue GetValue(string name, TemplateContext context)
public override ValueTask<FluidValue> GetValueAsync(string name, TemplateContext context)
{
return name switch
{
Expand Down