Skip to content

Avoid re-registration if member not found in UnsafeMemberAccessStrategy #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastienros merged 1 commit into from
Apr 21, 2025
Merged

Avoid re-registration if member not found in UnsafeMemberAccessStrategy #783

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions Fluid/UnsafeMemberAccessStrategy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
namespace Fluid
using System.Collections.Concurrent;

namespace Fluid
{
public sealed class UnsafeMemberAccessStrategy : DefaultMemberAccessStrategy
{
public static readonly UnsafeMemberAccessStrategy Instance = new UnsafeMemberAccessStrategy();
private readonly ConcurrentDictionary<Type, object> _handledTypes = new();

public static readonly UnsafeMemberAccessStrategy Instance = new();

public override IMemberAccessor GetAccessor(Type type, string name)
{
Expand All @@ -13,7 +17,11 @@ public override IMemberAccessor GetAccessor(Type type, string name)
return accessor;
}

this.Register(type);
if (!_handledTypes.ContainsKey(type))
{
this.Register(type);
_handledTypes.TryAdd(type, null);
}

return base.GetAccessor(type, name);
}
Expand Down