Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts dependency management for System.Text.Json by updating conditional compilation directives and test expectations to use the LTS version (8.0.5) and support different .NET target frameworks.
- Modified using directives and preprocessor conditions in MemberNameStrategies.cs.
- Updated the test assertions in TemplateTests.cs to reflect the new behavior for NET8_0_OR_GREATER.
- Removed a redundant using directive in TemplateOptions.cs.
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Fluid/MemberNameStrategies.cs | Updated preprocessor directives and modified member naming strategy methods. |
| Fluid.Tests/TemplateTests.cs | Revised expected outputs for member naming based on the new .NET conditions. |
| Fluid/TemplateOptions.cs | Removed an unnecessary using directive for System.Text.Json. |
Files not reviewed (3)
- Directory.Packages.props: Language not supported
- Fluid/Fluid.csproj: Language not supported
- Versions.props: Language not supported
Comments suppressed due to low confidence (1)
Fluid/MemberNameStrategies.cs:14
- The fields 'CamelCase' and 'SnakeCase' are declared but not assigned any values in the current configuration, which may lead to null reference issues at runtime. Consider assigning them to the appropriate renaming methods (e.g., 'RenameCamelCase' and 'RenameSnakeCase') in all target framework conditions.
public static readonly MemberNameStrategy CamelCase;
This was referenced Feb 24, 2026
This was referenced Mar 16, 2026
This was referenced Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use LTS version (8.0.5) when the dependency is required:
JsonNamingPolicyso the package is referenced