Adjust Where filter to properly handle truthy comparisons. #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add the failing case that triggered you filing the issue? Code looks good, I will have to debug to understand the differences ( don't remember the internals details) |
|
Added WhereWithUndefined test. Couldn't come up with a better name. |
| options.MemberAccessStrategy.Register(new { Title = "a", Pinned = true }.GetType()); | ||
| options.MemberAccessStrategy.Register(new { Title = "a", Pinned = true, Missing = 1 }.GetType()); | ||
|
|
||
| // x | where: "Missing" |
There was a problem hiding this comment.
What would be the behavior for where: Pinned, it's a boolean, I would expect 2. Can you add the test?
There was a problem hiding this comment.
It is 2 as you expect. The Where test (above WhereWithUndefined) already performs that check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects where to follow the
wheredocumentation from liquid language repository. Additionally, it deals with a case where the comparison value is actually false, which would lead to the comparison being performed with a true value.Corrects #620