Add replace_last and remove_last filters#515
Merged
sebastienros merged 5 commits intosebastienros:mainfrom Oct 18, 2022
Merged
Conversation
Owner
|
Awesome! Can you also add the missing test cases from here: This contains some with types that are not strings (I see it's implemented but not tested). |
Contributor
Author
|
Thanks for the quick feedback. No problem, I can add those. Need to run now, but will update the PR later today or likely tomorrow. |
Collaborator
|
Can you use |
1 similar comment
Collaborator
|
Can you use |
Owner
|
I added an extra unit test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bonus - add a missing assert statement in
RemovesReturnsInputWhenArgumentIsEmptyunit test.Resolve #494