Merged
Conversation
Owner
|
LGTM. Let me know when you are done. Would have been better with some new unit tests if you actually found an issue, or to show what the new calls to |
Contributor
Author
|
I write a new unit test to show why we should call to |
hishamco
requested changes
Dec 17, 2021
Collaborator
|
Looks good, last thing please check why the build fail |
Contributor
Author
I have fixed the problem of unit test errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I replaced the previous call to IMemberAccessor with GetValueAsync method