Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expression parsing in export default statements #417

Merged
merged 3 commits into from
Nov 4, 2023
Merged

Conversation

adams85
Copy link
Collaborator

@adams85 adams85 commented Nov 3, 2023

@adams85 adams85 requested a review from lahma November 3, 2023 19:55
Copy link
Collaborator

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue's test case seems to pass now. Should the test case be added to test suite too (I'm also fine with adding FluentAssertions as dependency as xUnit asserts are yucky anywa)?

@adams85
Copy link
Collaborator Author

adams85 commented Nov 4, 2023

Should the test case be added to test suite too

Absolutely, I just forgot to add it... :) Thanks for pointing this out.

I'm also fine with adding FluentAssertions as dependency as xUnit asserts are yucky anywa

Unfortunately, I'm not familiar with FluentAssertions but I don't think we'd need it for this one. However, feel free to add it if you see it useful.

@adams85 adams85 merged commit 4d80582 into main Nov 4, 2023
2 checks passed
@adams85 adams85 deleted the fix/issue416 branch November 4, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with parsing spread operator
2 participants