Skip to content

Conversation

@zickgraf
Copy link

@zickgraf zickgraf commented Jul 6, 2020

Depends on homalg-project/CAP_project#552

See commit messages for details. Commits should be reviewed separately.

In concrete applications some issues might arise:

  1. The same things might get computed multiple times for Source, Range and UnderlyingMatrix of a morphism.
  2. Code containing Lift/Colift cannot be compiled well because of the special case "fail".
  3. I'm not 100% sure that Julia actually inlines all the functions I create.

The first two issues could be fixed by different means -> I need concrete applications instead of toy examples to weigh the possible solutions. For the third issue I need someone with more knowledge of Julia than I have.

CC @mohamed-barakat

@zickgraf
Copy link
Author

zickgraf commented Jul 9, 2020

homalg-project/CAP_project#552 is merged, so in principle this is now ready for review. However, I'm not sure how to make the code in gap/CompilerLogic.gi "reviewable". It uses CapJitIterateOverTree, which has documentation in CompilerForCAP, but this is rather technical and requires knowledge of GAP's syntax trees (which lack documentation as mentioned before).

@zickgraf zickgraf marked this pull request as ready for review July 9, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant