Collect coverage when no assertion is expected#5010
Closed
mvorisek wants to merge 1 commit intosebastianbergmann:8.5from
mvorisek:fix_coverage_for_doesnotperformassertion
Closed
Collect coverage when no assertion is expected#5010mvorisek wants to merge 1 commit intosebastianbergmann:8.5from mvorisek:fix_coverage_for_doesnotperformassertion
mvorisek wants to merge 1 commit intosebastianbergmann:8.5from
mvorisek:fix_coverage_for_doesnotperformassertion
Conversation
Owner
|
Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it. |
This comment was marked as outdated.
This comment was marked as outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes sebastianbergmann/php-code-coverage#921 (comment)
when no assertion is expected - test is annotated with
@doesNotPerformAssertions(or with php attribute) - coverage must be collectedthe added condition matches the condition used a few lines below for reporting a risky test
🎉 UPDATE: It was actually fixed a yer later: b771002 and 262b0dc backported, thank you!