-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix trailing slash in XdebugFilterScriptGenerator - closes #3834 #3835
Conversation
Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have already fixed the issue in 002c0e2. My patch does not add |
Without addslashes it will lead to endquote being escaped by DIRECTORY_SEPARATOR and it will give a syntax error while running the tests. <?php declare(strict_types=1);
if (!\function_exists('xdebug_set_filter')) {
return;
}
\xdebug_set_filter(
\XDEBUG_FILTER_CODE_COVERAGE,
\XDEBUG_PATH_WHITELIST,
[
'C:\path\dir\'
]
);
Error: it should be |
This should properly add the trailing slash to files in
xdebug-filter.php
as reported in #3834