Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for checking subsets that contain duplicate values to ArraySubset #3186

Closed
wants to merge 6 commits into from
Closed

Add support for checking subsets that contain duplicate values to ArraySubset #3186

wants to merge 6 commits into from

Commits on Jun 27, 2018

  1. Test that ArraySubset can handle subsets with duplicate values.

    @pfrenssen
    pfrenssen committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    28ad5c3 View commit details
    Browse the repository at this point in the history

  2. Add support for matching subsets with duplicate values in ArraySubset.

    @pfrenssen
    pfrenssen committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    e27ecb3 View commit details
    Browse the repository at this point in the history

  3. Avoid trying to cast non-scalars to strings during sorting.

    @pfrenssen
    pfrenssen committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    39acf3b View commit details
    Browse the repository at this point in the history

  4. Improve readability of a line that uses multiple logical operators. 

    Since `&&` has a higher precendence than `||` the parentheses are unneeded
but adding them makes is easier to understand.
    @pfrenssen
    pfrenssen committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    3c8a4b7 View commit details
    Browse the repository at this point in the history

  5. Test a duplicate value located deep in a multidimensional array.

    @pfrenssen
    pfrenssen committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    b74749b View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2018

  1. Add regression test for issue sebastianbergmann#3240. 

    This proves that the bug reported in sebastianbergmann#3240 is also fixed in scope of this PR.
    @pfrenssen
    pfrenssen committed Aug 5, 2018
    Configuration menu
    Copy the full SHA
    c0c94e9 View commit details
    Browse the repository at this point in the history