-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expectExceptionMessageRegExp() has been removed in PHPUnit 9 without a deprecation warning being given in PHPUnit 8 #4133
Comments
|
|
Well, the initial commit intended to add the deprecation warning in 9 (see the linked commit) and remove in 10. That's why there is no warning in 8.4 and 8.5. The value of the warning is that I can work on the deprecation when seeing the warning (and all at once), rather than having to fix the fatal error due to the removed method, repeating this for each place using it until I don't get a fatal error anymore (or I could search |
PHPUnit 8.5.3 shows deprecation warnings when calling expectExceptionMessageRegExp. PHPUnit was updated from 8.5.2 to 8.5.2 at the beginning of this branch. See sebastianbergmann/phpunit#4133
…MessageMatches to provide FC with recent phpunit versions (soyuka) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] add PolyfillTestCaseTrait::expectExceptionMessageMatches to provide FC with recent phpunit versions | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | na | License | MIT | Doc PR | na expectExceptionMessageRegExp is deprecated coming phpunit 8.5.3 see sebastianbergmann/phpunit#4133 Not sure if I need to add something else lmk. Commits ------- cfd5a29 [PhpUnitBridge] add PolyfillTestCaseTrait::expectExceptionMessageMatches to provide FC with recent phpunit versions
…MessageMatches to provide FC with recent phpunit versions (soyuka) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] add PolyfillTestCaseTrait::expectExceptionMessageMatches to provide FC with recent phpunit versions | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | na | License | MIT | Doc PR | na expectExceptionMessageRegExp is deprecated coming phpunit 8.5.3 see sebastianbergmann/phpunit#4133 Not sure if I need to add something else lmk. Commits ------- cfd5a29eaf [PhpUnitBridge] add PolyfillTestCaseTrait::expectExceptionMessageMatches to provide FC with recent phpunit versions
…MessageMatches to provide FC with recent phpunit versions (soyuka) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] add PolyfillTestCaseTrait::expectExceptionMessageMatches to provide FC with recent phpunit versions | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | na | License | MIT | Doc PR | na expectExceptionMessageRegExp is deprecated coming phpunit 8.5.3 see sebastianbergmann/phpunit#4133 Not sure if I need to add something else lmk. Commits ------- cfd5a29eaf [PhpUnitBridge] add PolyfillTestCaseTrait::expectExceptionMessageMatches to provide FC with recent phpunit versions
…MessageMatches to provide FC with recent phpunit versions (soyuka) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] add PolyfillTestCaseTrait::expectExceptionMessageMatches to provide FC with recent phpunit versions | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | na | License | MIT | Doc PR | na expectExceptionMessageRegExp is deprecated coming phpunit 8.5.3 see sebastianbergmann/phpunit#4133 Not sure if I need to add something else lmk. Commits ------- cfd5a29eaf [PhpUnitBridge] add PolyfillTestCaseTrait::expectExceptionMessageMatches to provide FC with recent phpunit versions
…MessageMatches to provide FC with recent phpunit versions (soyuka) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] add PolyfillTestCaseTrait::expectExceptionMessageMatches to provide FC with recent phpunit versions | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | na | License | MIT | Doc PR | na expectExceptionMessageRegExp is deprecated coming phpunit 8.5.3 see sebastianbergmann/phpunit#4133 Not sure if I need to add something else lmk. Commits ------- cfd5a29eaf [PhpUnitBridge] add PolyfillTestCaseTrait::expectExceptionMessageMatches to provide FC with recent phpunit versions
…MessageMatches to provide FC with recent phpunit versions (soyuka) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] add PolyfillTestCaseTrait::expectExceptionMessageMatches to provide FC with recent phpunit versions | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | na | License | MIT | Doc PR | na expectExceptionMessageRegExp is deprecated coming phpunit 8.5.3 see sebastianbergmann/phpunit#4133 Not sure if I need to add something else lmk. Commits ------- cfd5a29eaf [PhpUnitBridge] add PolyfillTestCaseTrait::expectExceptionMessageMatches to provide FC with recent phpunit versions
…MessageMatches to provide FC with recent phpunit versions (soyuka) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] add PolyfillTestCaseTrait::expectExceptionMessageMatches to provide FC with recent phpunit versions | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | na | License | MIT | Doc PR | na expectExceptionMessageRegExp is deprecated coming phpunit 8.5.3 see sebastianbergmann/phpunit#4133 Not sure if I need to add something else lmk. Commits ------- cfd5a29eaf [PhpUnitBridge] add PolyfillTestCaseTrait::expectExceptionMessageMatches to provide FC with recent phpunit versions
…MessageMatches to provide FC with recent phpunit versions (soyuka) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] add PolyfillTestCaseTrait::expectExceptionMessageMatches to provide FC with recent phpunit versions | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | na | License | MIT | Doc PR | na expectExceptionMessageRegExp is deprecated coming phpunit 8.5.3 see sebastianbergmann/phpunit#4133 Not sure if I need to add something else lmk. Commits ------- cfd5a29eaf [PhpUnitBridge] add PolyfillTestCaseTrait::expectExceptionMessageMatches to provide FC with recent phpunit versions
…MessageMatches to provide FC with recent phpunit versions (soyuka) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] add PolyfillTestCaseTrait::expectExceptionMessageMatches to provide FC with recent phpunit versions | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | na | License | MIT | Doc PR | na expectExceptionMessageRegExp is deprecated coming phpunit 8.5.3 see sebastianbergmann/phpunit#4133 Not sure if I need to add something else lmk. Commits ------- cfd5a29eaf [PhpUnitBridge] add PolyfillTestCaseTrait::expectExceptionMessageMatches to provide FC with recent phpunit versions
PHPUnit 8.5.3 shows deprecation warnings when calling expectExceptionMessageRegExp. PHPUnit was updated from 8.5.2 to 8.5.2 at the beginning of this branch. See sebastianbergmann/phpunit#4133
PHPUnit 8.5.3 shows deprecation warnings when calling expectExceptionMessageRegExp. PHPUnit was updated from 8.5.2 to 8.5.2 at the beginning of this branch. See sebastianbergmann/phpunit#4133
…MessageMatches to provide FC with recent phpunit versions (soyuka) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] add PolyfillTestCaseTrait::expectExceptionMessageMatches to provide FC with recent phpunit versions | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | na | License | MIT | Doc PR | na expectExceptionMessageRegExp is deprecated coming phpunit 8.5.3 see sebastianbergmann/phpunit#4133 Not sure if I need to add something else lmk. Commits ------- cfd5a29eaf [PhpUnitBridge] add PolyfillTestCaseTrait::expectExceptionMessageMatches to provide FC with recent phpunit versions
…MessageMatches to provide FC with recent phpunit versions (soyuka) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] add PolyfillTestCaseTrait::expectExceptionMessageMatches to provide FC with recent phpunit versions | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | na | License | MIT | Doc PR | na expectExceptionMessageRegExp is deprecated coming phpunit 8.5.3 see sebastianbergmann/phpunit#4133 Not sure if I need to add something else lmk. Commits ------- cfd5a29eaf [PhpUnitBridge] add PolyfillTestCaseTrait::expectExceptionMessageMatches to provide FC with recent phpunit versions
Summary
The commit introducing
expectExceptionMessageMatches
says thatexpectExceptionMessageRegExp
will trigger a warning in 9 and be removed in 10.But the 9.0 removed the method entirely instead of adding a warning in it. This means that the method got removed without ever reporting a deprecation warning when running tests using it.
And there is no changelog saying that this method is deprecated (the PHPUnit 8 changelog does not talk about deprecating
expectExceptionMessageRegExp
and the PHPUnit 9 changelog says it is removed).The text was updated successfully, but these errors were encountered: