Skip to content

Commit

Permalink
Prevent illogical values for high lower bound and low upper bound
Browse files Browse the repository at this point in the history
  • Loading branch information
sebastianbergmann committed Feb 21, 2022
1 parent 18fad58 commit 8eaae8d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
4 changes: 4 additions & 0 deletions ChangeLog-8.5.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ All notable changes of the PHPUnit 8.5 release series are documented in this fil

* [#4874](https://github.com/sebastianbergmann/phpunit/pull/4874): `PHP_FLOAT_EPSILON` is now used instead of hardcoded `0.0000000001` in `PHPUnit\Framework\Constraint\IsIdentical`

### Fixed

* When the HTML code coverage report's configured low upper bound is larger than the high lower bound then the default values are used instead

## [8.5.23] - 2022-01-21

### Fixed
Expand Down
5 changes: 5 additions & 0 deletions src/TextUI/TestRunner.php
Original file line number Diff line number Diff line change
Expand Up @@ -1285,6 +1285,11 @@ private function handleConfiguration(array &$arguments): void
$arguments['timeoutForMediumTests'] = $arguments['timeoutForMediumTests'] ?? 10;
$arguments['timeoutForSmallTests'] = $arguments['timeoutForSmallTests'] ?? 1;
$arguments['verbose'] = $arguments['verbose'] ?? false;

if ($arguments['reportLowUpperBound'] > $arguments['reportHighLowerBound']) {
$arguments['reportLowUpperBound'] = 50;
$arguments['reportHighLowerBound'] = 90;
}
}

private function processSuiteFilters(TestSuite $suite, array $arguments): void
Expand Down

0 comments on commit 8eaae8d

Please sign in to comment.