Properly initialize TestSuiteIterator.position

Now this field always is an integer, following up on the promise given by the type annotation.
sebastianbergmann · Sep 7, 2019 · 7fdbf5c · 7fdbf5c
1 parent 4f201f7
commit 7fdbf5c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/src/Framework/TestSuiteIterator.php b/src/Framework/TestSuiteIterator.php
@@ -19,7 +19,7 @@ final class TestSuiteIterator implements RecursiveIterator
     /**
      * @var int
      */
-    private $position;
+    private $position = 0;
 
     /**
      * @var Test[]

diff --git a/tests/unit/Framework/TestSuiteIteratorTest.php b/tests/unit/Framework/TestSuiteIteratorTest.php
@@ -20,8 +20,6 @@ final class TestSuiteIteratorTest extends TestCase
 
     public function testKeyForEmptyTestSuiteInitiallyReturnsZero(): void
     {
-        $this->markTestSkipped('This test needs a bug fix to pass.');
-
         $testSuite = new TestSuite();
         $subject   = new TestSuiteIterator($testSuite);
 
@@ -52,8 +50,6 @@ public function testCurrentForEmptyTestSuiteInitiallyReturnsNull(): void
 
     public function testKeyForNonEmptyTestSuiteInitiallyReturnsZero(): void
     {
-        $this->markTestSkipped('This test needs a bug fix to pass.');
-
         $testSuite = new TestSuite();
         $testSuite->addTest(new \EmptyTestCaseTest());
         $subject = new TestSuiteIterator($testSuite);
@@ -72,8 +68,6 @@ public function testValidForNonEmptyTestSuiteInitiallyReturnsTrue(): void
 
     public function testCurrentForNonEmptyTestSuiteInitiallyReturnsFirstTest(): void
     {
-        $this->markTestSkipped('This test needs a bug fix to pass.');
-
         $test      = new \EmptyTestCaseTest();
         $testSuite = new TestSuite();
         $testSuite->addTest($test);