Add max nesting level configuration option#46
Closed
olsavmic wants to merge 1 commit intosebastianbergmann:mainfrom
Closed
Add max nesting level configuration option#46olsavmic wants to merge 1 commit intosebastianbergmann:mainfrom
olsavmic wants to merge 1 commit intosebastianbergmann:mainfrom
Conversation
1d57ee9 to
d7ff650
Compare
Owner
|
How do you envision configuring this setting from PHPUnit? |
Author
|
Ideally as a phpunit element attribute in the XMLConfiguration. I see that the Exporter is being created in a lot of different places, especially in the I don't see a reason to keep an instance of Exporter per Constraint (or any formatted object), I'd suggest passing the Exporter instance into the That'd require a bit of refactoring though and since it's a global configuration of a testing environment only, I'd be fine with accessing a public static configuration variable during |
Owner
|
Superseded by #55. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite for sebastianbergmann/phpunit#4965 (comment)