Repository navigation
Complete the reopened context-budget source audit - #818
Conversation
345b8d0 to
9e0992b
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…egistry plus the owned rows) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…fore the final hot-file commit Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… (hot-file protocol: every hot-file edit in the last commit) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude session native-agent-stack-5f: landing at head Observed main Required checks at this head: 7 pass . Unresolved review threads: 0. |
|
Claude session native-agent-stack-5f: post-merge observation. Landed as |
### Scope Add the prescribed plain-sed SKILL.md exception so Codex can recognize a registered skill-document invocation despite the RTK blanket prefix. Preserve the six existing exceptions, add the seventh entry, and render the ten role carriers and new-WSL user-instruction copy through the repository's helpers. No role grants, model settings or host files change. - Landing-rebase base: `e712bae606e8d27f010af8e3c13ded6b7a7c207a`. - Head: `305a4859d06e36d54d339924389f468ed70e3de4`. - Lane: `lane:foundation`; draft. - Owned paths: Codex template/carriers, current render expectations and byte-count comments, README hashes and its exact upstream-surface citation, dated decision/receipt, native generated current inventory and registry/checksums. - The one explicitly cued landing rebase retains main's local-time instruction and protected-prefix pin. Native compact/rendered sizes are 7,798/8,864 bytes. The README's `otel.environment` command and disposition both name line188. - Main's registry was retained and exactly 23 owned rows re-registered with the repository helper. The last commit contains the two Codex checksum files, the scoped citation, the appended current generated inventory, the unchanged original receipt and the registry. Landing path: command-center ACK at the pre-rebase `f0d1c6d04` head; the co-op/5f verify this explicitly cued landing head and CI. 5f lands #803 after #818, then #819 takes its own landing cue. This lane does not merge or apply the installed instruction file. ## SOTA sources - [openai/codex@a956835d (rust-v0.160.0), parse_command.rs:1567-1629](https://github.com/openai/codex/blob/a956835d020762cb2b570053af06f643a11c0ecc/codex-rs/shell-command/src/parse_command.rs#L1567-L1629) and [2708-2715](https://github.com/openai/codex/blob/a956835d020762cb2b570053af06f643a11c0ecc/codex-rs/shell-command/src/parse_command.rs#L2708-L2715): plain numeric-range sed reads. - [normalize_tokens:1636-1652](https://github.com/openai/codex/blob/a956835d020762cb2b570053af06f643a11c0ecc/codex-rs/shell-command/src/parse_command.rs#L1636-L1652) and [Unknown fallback:2734-2737](https://github.com/openai/codex/blob/a956835d020762cb2b570053af06f643a11c0ecc/codex-rs/shell-command/src/parse_command.rs#L2734-L2737): simple RTK prefixes are not unwrapped into native reads. - [skills/invocation.rs:129-143](https://github.com/openai/codex/blob/a956835d020762cb2b570053af06f643a11c0ecc/codex-rs/skills/src/invocation.rs#L129-L143), [core/skills.rs:153-197](https://github.com/openai/codex/blob/a956835d020762cb2b570053af06f643a11c0ecc/codex-rs/core/src/skills.rs#L153-L197) and [exec_command.rs:254-263](https://github.com/openai/codex/blob/a956835d020762cb2b570053af06f643a11c0ecc/codex-rs/core/src/tools/handlers/unified_exec/exec_command.rs#L254-L263): canonical registered path, per-turn deduplication and invocation event before execution. This counts an invocation attempt, not a successful full read. The prescribed recipe excludes cat/head/tail although upstream also recognizes cat. - `native-agent-stack@305a485:tools/adoption/managed_block.py:169` (`codex_block`), `tools/adoption/codex_roles.py:287` (`f4_block`) and `scripts/host_receipts.py:710` (`register_file`); `native-agent-stack@e712bae:docs/lanes.md:94-128`: existing native rendering and hot-file protocol. - [Current README launch:188](https://github.com/seathatflowsinourveins/native-agent-stack/blob/305a4859d06e36d54d339924389f468ed70e3de4/examples/codex-native/README.md#L188): exact `otel.environment` source locator; other owner rows preserved. ### Evidence-class table | Claim | Evidence class | Command / receipt | | --- | --- | --- | | Native skill-read recognition and RTK-wrapper limitation | `source_review` | Pinned vendor source above | | Seven exceptions, 11 rendered copies, current inventory and checksum agreement | `local_integration` | Existing native render/check helpers and required modules; original dated receipt preserved | | Writer refusal, rollback and citation controls | `synthetic` | Existing repository fixtures and mutation controls; no upstream test acceptance claim | | Deployed behavior | Pending owner evidence | CC applies and reads back the installed instruction file; no model run or host apply here | ### Local commands run The six required modules ran once on the clean rebased head, under `CI=true`, umask022, nice19 and ionice-c3: ```text python3 -B -m unittest tests.test_codex_agents tests.test_codex_worker_lane tests.test_managed_block tests.test_codex_roles tests.test_new_wsl_client_config tests.test_upstream_surface_watch exit0; 562 tests / 152.864 seconds / 18 skips python3 tools/adoption/new_wsl_client_config.py --check --markdown exit0; current tables and inventory agree python3 scripts/validate.py exit0; 69 components / 10,419 registered files / 4 profiles / 224 receipts sha256sum --check --strict SHA256SUMS exit0 in both adoption/agents/codex and adoption/agents/codex/workers python3 scripts/component_matrix.py --write exit0 python3 scripts/new_host_grand_list.py --write exit0 git diff --check exit0; final worktree clean ``` Validation ran on the final source bytes before continuing the last evidence commit; those inputs remained unchanged through commit and the module run. Full hosted CI at this new head remains the owner’s acceptance step. Complete local output is durable under `lanes/codex-token-parity-work/803-20261007/`; no new model, provider or GPU run is claimed. The same single rebase had two expected conflict stops: owned descriptive byte comments, then the shared registry. The comments now use native renderer counts while preserving main's pin and assertions; the registry resolution uses main plus native registration. No second rebase, abort or reset. Earlier failed import/fixture-mode/hash runs and earlier CI citation failures remain in the dated receipt and durable logs. ### Decision record `docs/decisions/2026-10-06-codex-skill-read-exception.md` records evidence, alternatives, limits and the upstream change that would overturn the recipe. The client-configuration record's new dated inventory is appended; its decided text, main's addendum and the original observed receipt are preserved. ### Host evidence No `evidence/hosts/` change, native model run, installed instruction-file edit, RTK hook/configuration edit or client apply. The command center owns host application after acceptance. Local integrity and synthetic tests are separate from deployed-client acceptance. ### Checklist - [x] No workflow/action or role-grant change. - [x] No credentials, raw conversations or active client configuration committed. - [x] No paid service or dependency. - [x] Other owners' branches and worktrees preserved. - [x] Main registry retained; native own-row registration and checksum/registry last.
Scope
Complete the reopened C5 source audit: review six names and three instruction documents, retain native defaults for the names, and apply their nine current disposition rows. The unchanged main-catalog watch returned nine unreviewed items; the candidate now returns zero with all document hashes matching.
SOTA sources
Evidence-class table
Local commands run
All substantive commands ran at nice19/ionice3.
Two earlier watch usage failures exit2 before fetch because the long worktree could not fit the160-character details summary. Both are retained; a supported per-invocation Worktrunk short owned path/no-hooks resolves the command without saved settings changes.
Decision record
docs/decisions/2026-10-06-harness-context-budget-completion.md and evidence/artifacts/ns2604-context-audit-completion-20261006/review.json. Keep native defaults; revisit on a supported release and qualified host need, or any changed instruction-body digest. Previous reviewed body bytes were unavailable, so no historical semantic delta is invented. Source review does not establish runtime acceptance or token savings.
Host evidence
No evidence/hosts file, host installation or platform-status change. Local catalog-candidate zero is separate from landed-main or deployed-client state.
Checklist