Repository navigation
OmniRoute Mac gateway: LE-18 read-only checks and version 2 of the update check - #638
seathatflowsinourveins wants to merge 4 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aec1c5d779
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
aec1c5d to
237c40e
Compare
…can, bounded reads, delivery-based state, retained tests, completeness critic) The automated review of #638 found eight defects. The capability scan now checks structure (the Sol model object in the server bundle; the alpha search route in the server's app-paths manifest with its route file) and is a notice, never a switch gate. Reads are bounded per package, per file and in total. Repeat-suppressing state is written only after a notification is delivered, a failed package read stays pending, a failed PR lookup keeps the PR's record, and the capability result is kept. The 16-case suite, its red check against the first deployment, both capability controls, the dry run and the first real run are retained; the receipt records a completeness critic. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…can, bounded reads, delivery-based state, retained tests, completeness critic) The automated review of #638 found eight defects. The capability scan now checks structure (the Sol model object in the server bundle; the alpha search route in the server's app-paths manifest with its route file) and is a notice, never a switch gate. Reads are bounded per package, per file and in total. Repeat-suppressing state is written only after a notification is delivered, a failed package read stays pending, a failed PR lookup keeps the PR's record, and the capability result is kept. The 16-case suite, its red check against the first deployment, both capability controls, the dry run and the first real run are retained; the receipt records a completeness critic. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
de27a20 to
8a1a983
Compare
…date check Answers the first two items of issue 624's LE-18 (Mac OmniRoute service owner): the running build's fingerprint (BUILD_SHA 6f246e84a, tarball sha256 d602dc42...), the process title (the bundled Next.js 16.3.5), the update-check state, and the effort read-back, which the gateway's call-log APIs cannot give (no effort field; the database stays unopened). Version 2 of the update check notifies when a carried PR closes unmerged or a new release appears, with a read-only capability scan of the release package (Sol catalog entry, /v1/alpha/search). Deployed with version 1 kept as the rollback; positive and negative controls, a dry run and stubbed paths recorded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…can, bounded reads, delivery-based state, retained tests, completeness critic) The automated review of #638 found eight defects. The capability scan now checks structure (the Sol model object in the server bundle; the alpha search route in the server's app-paths manifest with its route file) and is a notice, never a switch gate. Reads are bounded per package, per file and in total. Repeat-suppressing state is written only after a notification is delivered, a failed package read stays pending, a failed PR lookup keeps the PR's record, and the capability result is kept. The 16-case suite, its red check against the first deployment, both capability controls, the dry run and the first real run are retained; the receipt records a completeness critic. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
8a1a983 to
b020127
Compare
|
Closed with a record by the PR triage of 2026-10-07 (the command center's ruling, item review-ns2604-coop-20261007T023012Z (the command center's PR-triage ruling of 2026-10-07; proposal by github-ci-finalize, triage-20261007.json)). Not merged; the branch What it holds: docs/decisions/2026-10-02-omniroute-mac-rebuild.md (LE-18 and update-check v2 sections); evidence/artifacts/omniroute-mac-rebuild-20261002/le18-20261003.json; evidence/artifacts/omniroute-mac-rebuild-20261002/checks/ (8 new files, update-check v2 tests); scripts/ (1 new), README.md (modified) Superseded by: not superseded; unprioritized under the 2026-10-07 PR triage (confidence: medium: LE-18's third item landed separately in e70afbb (#637; manifests/stack.json:1900 is 3.8.51); the user's 2026-10-05 decision treats the Mac as portable or remote-control only (docs/decisions/2026-10-05-macos-ci-advisory.md:10); nothing on main replaces the Mac update-check v2 or LE-18 items 1-2, and issue #624 is open) Reopen trigger: The Mac returns to serving an OmniRoute gateway beyond portable or remote-control use, or LE-18 items 1-2 of issue #624 are raised again for the Mac service owner. Reopen with |
Scope
d2777ee7(main, after Keep the root directory as one PATH component; refuse a host HOME of /; six anti-pattern log rows #619).lane:foundation.docs/decisions/2026-10-02-omniroute-mac-rebuild.md(new section "Update, 2026-10-03")evidence/artifacts/omniroute-mac-rebuild-20261002/:le18-20261003.jsonandscripts/omniroute-update-check.v2.py.txt(new),README.mdmanifests/evidence.json(registration, in the last commit)omnirouterow ofmanifests/stack.json. It is the lane:shared manifest owner's change.Results
Running build. The listener on port 20128 started at the switch of Rebuild the Mac's OmniRoute gateway with GPT-6.1 Sol and follow the installed Codex version #599 (2026-10-02T03:44:48Z) from this build.
dist/BUILD_SHAis6f246e84a.d602dc42….The process title
omniroute (v16.3.5)names the bundled Next.js 16.3.5, not OmniRoute's version. Next's start-server setsnext-server (v16.3.5), and OmniRoute's startup instrumentation renames it.Effort read-back: not possible through the gateway's APIs.
maxanswered 200.Update check, version 2. It still installs nothing. It adds a notification for:
/api/v1/alpha/search/routemanifest entry with its route file. Its result is a notice, never a switch gate.Review round. The automated review's eight findings are answered in
021695e2and all eight threads are resolved:The revised script was redeployed at 10:02Z (sha256
dd79843c…).SOTA sources
https://registry.npmjs.org/omniroute/<version>,dist.tarballanddist.integrity), read without installing.packages/next/src/server/lib/start-server.ts, which sets thenext-server (vX)process title; it ships in the installed package asdist/server/lib/start-server.jsline 180.Evidence-class table
6f246e84afrom tarballd602dc42…local_integrationle18-20261003.json→read_only_checks.fingerprintsource_reviewlocal_integrationle18-20261003.json→read_only_checks.effort_read_backlocal_integration,syntheticchecks/update-check-v2/: 16-case suite (all passed), red check against the first deployment, controls (own package: both; v3.8.51: neither), dry run, first real runLocal commands run
Host evidence
Not applicable: no file under
evidence/hosts/changes.Checklist
version comment (no floating tags). (No workflow changes.)
permissions: contents: read(or a narrower, explicitly justified addition). (No workflow changes.)
added without a documented owner.
moved or overwritten).
🤖 Generated with Claude Code