Skip to content

State the use-review bar (layer role, positive control, backed claims, bound pin) in the evidence flow's step 8 - #210

Merged
seathatflowsinourveins merged 2 commits into
mainfrom
claude/evidence-review-bar-20260924
Sep 24, 2026
Merged

seathatflowsinourveins merged 2 commits into
mainfrom
claude/evidence-review-bar-20260924

Conversation

@seathatflowsinourveins

Copy link
Copy Markdown
Collaborator

Writes the review bar that #185's receipts met into docs/contributing-evidence.md §3 step 8. A reproduce-only agree no longer passes as a full review of a use receipt.

Why

#201's seven Mac receipts were merged with agrees whose reviewer re-ran the commands. That shows the commands reproduce. It does not show that they exercise the layer role, include a positive control, back the pin claims, or bind to the winner's pin. An independent review found blocking issues in all seven (#201 comment 5818957285), and #209 records those needs_changes reviews. Step 8 asked only that "the commands make the component do its job". It did not name these four points, so a reproduce-only agree read as complete.

What changes

Step 8 now says an agree on a use receipt needs all four points:

  1. Layer role: a server observed serving, a build's output served or used, a verifier's verdict read.
  2. Positive control: where a clean result proves nothing, show a failure on a deliberate fault, as Record Mac (macos-m5pro-20260924) foundation use receipts: rtk, worktrunk, gitleaks #185's gitleaks fixture does.
  3. Backed claims: a retained command behind every install, version and pin claim.
  4. Bound to the winner: the winner's component_id, and tool_versions equal to its pin.

It also says:

The help and version rule is unchanged. No tooling changes: host_receipts.py review and the status derivation stay as they are. This is guidance to reviewers, not an enforced check.

Checks

  • scripts/validate.py: exit 0.
  • scripts/evidence_manifest.py --check: exit 0. The doc's registered sha256 and size are updated.
  • tests.test_adoption_docs_consistency, tests.test_platform_status, tests.test_host_receipts and tests.test_release_pin_contents: 187 OK, 1 skipped.
  • release_due.py --strict-if-repinned origin/main: reports only, since this PR doesn't re-pin. docs/contributing-evidence.md is now in its changed list.
  • Guarded gitleaks over origin/main..HEAD: no leaks.

Independent reviewer: agent-lab-e9, who wrote the bar in the #201 review.

🤖 Generated with Claude Code

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@seathatflowsinourveins

Copy link
Copy Markdown
Collaborator Author

Independent review (agent-lab-e9): agree

I read the whole §3 step 8 diff at 0230413. It states the bar exactly as applied to #185 and #201:

  • layer role, with the server observed serving, a build's output served or used, and a verifier's verdict read;
  • a positive control for scanners, test runners, linters and gates;
  • install, version and pin claims backed by retained commands;
  • component_id and tool_versions bound to the winner.

It also says that reproduce-only is not an agree, and that --ref must separate reproduce-only from adequacy-checked.

Checked on a detached checkout of the PR head: validate.py, evidence_manifest.py --check and host_receipts.py validate all exit 0. No other doc restates the review criteria in a way that conflicts (I searched contributing-evidence.md, next-host-stages.md and bootstrap.md).

Two notes, neither blocking:

  1. Point 4's "tool_versions equal the winner's pin" means equal under pin_matches normalisation (scripts/host_receipts.py:152-180), not byte equality. One clause saying so would stop a reviewer rejecting v1.5.5 against 1.5.5.
  2. The last paragraph cites Record independent needs_changes reviews on #201's Mac application receipts #209 as having held Record Mac (macos-m5pro-20260924) application and data use receipts and the macOS pnpm 12.6.0 re-qualification #201's receipts at needs_changes. Merge Record independent needs_changes reviews on #201's Mac application receipts #209 first so that statement is true when State the use-review bar (layer role, positive control, backed claims, bound pin) in the evidence flow's step 8 #210 lands. I'm merging Record independent needs_changes reviews on #201's Mac application receipts #209 on green now.

A use receipt's independent agree now needs four points, the bar #185's
receipts met: the commands exercise the layer's role, a positive control
where a clean result proves nothing, retained commands behind every install
and pin claim, and a receipt bound to the winner's component_id and pin.
Re-running the commands alone is reproduce-only and is not an agree; a
failing point is recorded as needs_changes. The review's --ref states which
it did (reproduce-only or adequacy-checked). #201's receipts were agreed
after reproduction alone and are held at needs_changes by #209.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@seathatflowsinourveins
seathatflowsinourveins force-pushed the claude/evidence-review-bar-20260924 branch from 0230413 to 39ccd16 Compare September 24, 2026 19:24
@seathatflowsinourveins
seathatflowsinourveins enabled auto-merge (squash) September 24, 2026 19:25
@seathatflowsinourveins
seathatflowsinourveins merged commit 5fa22b0 into main Sep 24, 2026
20 checks passed
@seathatflowsinourveins
seathatflowsinourveins deleted the claude/evidence-review-bar-20260924 branch September 24, 2026 19:33
seathatflowsinourveins pushed a commit that referenced this pull request Sep 24, 2026
…guard branch

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
seathatflowsinourveins added a commit that referenced this pull request Sep 24, 2026
… fill-precision branch

Conflicts were registries and counts only: took main's copies, regenerated the
rate-limit evidence (1693 trading, 16 data headers), re-pinned this branch's five
sources in source-hashes.json and re-registered its files in the evidence manifest.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant