Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Add support for aggregation #148

Closed
wants to merge 1 commit into from
Closed

Conversation

hlassiege
Copy link

(only the extended stats aggregation, just for demonstration purpose)

@hlassiege
Copy link
Author

Travis CI failed because of
"java.lang.OutOfMemoryError: unable to create new native thread"

Is it something recurrent ?

@kramer
Copy link
Member

kramer commented Sep 19, 2014

Hmm that's something new. (I'll try to have a look at this but cannot promise anything for this&next week, sorry)

@hlassiege
Copy link
Author

no problem. Currently I'm using the old StatisticalFacet.

@kramer kramer added this to the v0.1.3 milestone Sep 19, 2014
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.12%) when pulling 8756eb3 on hlassiege:master into 93d46d4 on searchbox-io:master.

@kramer
Copy link
Member

kramer commented Sep 30, 2014

Hey,

Sorry it took so long to look into this.
I just realized getFacets does not belong in JestResult but in SearchResult instead (same goes for getAggregation in your commit); so I'll be refactoring those first. Therefore I won't be merging this PR but will work on the request after facet-refactor. (also you are missing tests 😛)

Regardless, thanks a lot for your effort! 🍻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants