-
Notifications
You must be signed in to change notification settings - Fork 727
added JestHttpClient logging information #124
Conversation
1. reuqest method and url. 2. request body to jsonString.
They should probably be on debug level instead of info as it'll get too chatty otherwise 😄 |
ok. i changed logging level to debug. |
|
||
JsonElement el = new JsonParser().parse(entity); | ||
|
||
log.debug("request body to json - " + System.getProperty("line.separator") + new GsonBuilder().setPrettyPrinting().create().toJson(el)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not create a new Gson instance and use the one set on the class instead (getGson()
). Also why not just print entity
; yes it won't be pretty printed but that is the actual entity and doing a json parse for the second time here is kinda wasteful.
If you are using prettyPrint. |
what do you think, |
after that,
} |
2.method modifier changed. - JestHttpClient.createJsonStringEntity(from private to protected)
added JestHttpClient debug logging information
hello.
i use RoundrobinServerList by JestHttpClient.
normally, i think we need to know to below informations for the debugging.
specially, when you use RoundRobinServer Method.
clearly need to know that information.
because according to the roundRobin method, change host at the call each time.
so i added logging information.
how are you thinking?
would you please to accept my pull request?
thank you.