JSON in alias filter is unnecessarily escaped

[igor-kupczynski]

Hi,

If you want to create an alias with a filter you should use a json like this ([src])(http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/indices-aliases.html):

curl -XPOST 'http://localhost:9200/_aliases' -d '
{
    "actions" : [
        {
            "add" : {
                 "index" : "test1",
                 "alias" : "alias2",
                 "filter" : { "term" : { "user" : "kimchy" } }
            }
        }
    ]
}'

The problem is that JEST escapes the JSON query in the filter object which results in something like this:

curl -XPOST 'http://localhost:9200/_aliases' -d '
{
    "actions" : [
        {
            "add" : {
                 "index" : "test1",
                 "alias" : "alias2",
                 "filter" : { \"term\" : { \"user\" : \"kimchy\" } }
            }
        }
    ]
}'

I'll submit a test case shortly...

[igor-kupczynski]

For example this test

Index: jest-common/src/test/java/io/searchbox/indices/aliases/AddAliasMappingTest.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- jest-common/src/test/java/io/searchbox/indices/aliases/AddAliasMappingTest.java (revision 59b4e9f6b8b21ed5a9edcf4366ed5473174cc347)
+++ jest-common/src/test/java/io/searchbox/indices/aliases/AddAliasMappingTest.java (revision )
@@ -37,11 +37,12 @@
     public void testGetDataForJsonWithFilterAndRouting() {
         AddAliasMapping addAliasMapping = new AddAliasMapping
                 .Builder("tIndex", "tAlias")
-                .setFilter("my_query")
+                .setFilter("{\"term\":{\"user\":\"kimchy\"}}")
                 .addRouting("1")
                 .build();
         String actualJson = new Gson().toJson(addAliasMapping.getData()).toString();
-        String expectedJson = "[{\"add\":{\"search_routing\":\"1\",\"index\":\"tIndex\",\"alias\":\"tAlias\",\"index_routing\":\"1\",\"filter\":\"my_query\"}}]";
+        String expectedJson = "[{\"add\":{\"search_routing\":\"1\",\"index\":\"tIndex\",\"alias\":\"tAlias\"," +
+                "\"index_routing\":\"1\",\"filter\":\"{\"term\":{\"user\":\"kimchy\"}}\"}}]";

         assertEquals(expectedJson, actualJson);
     }

Fails with a message:

org.junit.ComparisonFailure: 
Expected :[{"add":{"search_routing":"1","index":"tIndex","alias":"tAlias","index_routing":"1","filter":"{"term":{"user":"kimchy"}}"}}]
Actual   :[{"add":{"search_routing":"1","index":"tIndex","alias":"tAlias","index_routing":"1","filter":"{\"term\":{\"user\":\"kimchy\"}}"}}]

Should this #setFilter(String) be changed to #setFilter(JsonObject)? What do you think?

[igor-kupczynski]

Hi, I posted a possible solution, can you take a look and advise what needs to be done to get it merged to JEST?

[kramer]

Thanks for the clean bug report and the contribution, we really appreciate it. Please see my comments on #128 for further discussion.

[kramer]

Merged #128, thanks again for the contribution.

[igor-kupczynski]

NP, Thanks for merging