bugfix: unsynchronized iterator usage in getNextServer was not thread…

… safe.
searchbox-io · Mar 31, 2015 · e67f6ab · e67f6ab
1 parent bc3178a
commit e67f6ab
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/jest-common/src/main/java/io/searchbox/client/AbstractJestClient.java b/jest-common/src/main/java/io/searchbox/client/AbstractJestClient.java
@@ -69,8 +69,10 @@ public void shutdownClient() {
      */
     protected String getNextServer() {
         Iterator<String> iterator = serverPoolReference.get().getValue();
-        if (iterator.hasNext()) return iterator.next();
-        else throw new NoServerConfiguredException("No Server is assigned to client to connect");
+        synchronized (iterator) {
+            if (iterator.hasNext()) return iterator.next();
+            else throw new NoServerConfiguredException("No Server is assigned to client to connect");
+        }
     }
 
     protected int getServerPoolSize() {