WIP - Filter for HTTP basic authentication #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I need a filter to handle HTTP basic authentication. I saw that there were efforts to implement this in #62, but without any results.
This is a minimal implementation for such a filter. It's just extracting the header, or sends a rejection if the header was not sent by the client. The consumer still has to check if the credentials sent by the client are valid.
Futhermore it's currently not sending back a
WWW-Authenticateheader in the rejection. How would I go about adding a header to a rejection?If there are any other things that should be changed here, please let me know. I'd also be interested in adding or allowing the possibility to add more authentication methods.