Skip headers for Not Modified fs responses #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to RFC 7232, 304 Not Modified responses should not generate representation metadata other than the following fields: Cache-Control, Content-Location, Date, ETag, Expires, and Vary. This avoids a warning from hyper when logging is enabled: "content-length value found, but empty body provided". While it is allowed to provide Content-Length for Not Modified responses it is unnecessary.
|
Depends on hyperium/hyper#1797 to be fixed, after actually testing this in practice. Providing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC 7232, 304 Not Modified responses should not generate representation metadata other than the following fields: Cache-Control, Content-Location, Date, ETag, Expires, and Vary.
This avoids a warning from hyper when logging is enabled: "content-length value found, but empty body provided". While it is allowed to provide Content-Length for Not Modified responses it is unnecessary.