Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/async_impl/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2442,7 +2442,14 @@ impl Client {
///
/// This method fails whenever the supplied `Url` cannot be parsed.
pub fn request<U: IntoUrl>(&self, method: Method, url: U) -> RequestBuilder {
let req = url.into_url().map(move |url| Request::new(method, url));
let req = url.into_url().map(move |url| {
let mut req = Request::new(method, url);
let headers = req.headers_mut();
for (key, value) in &self.inner.headers {
headers.insert(key, value.clone());
}
req
});
RequestBuilder::new(self.clone(), req)
}

Expand Down
9 changes: 8 additions & 1 deletion src/blocking/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1289,7 +1289,14 @@ impl Client {
///
/// This method fails whenever supplied `Url` cannot be parsed.
pub fn request<U: IntoUrl>(&self, method: Method, url: U) -> RequestBuilder {
let req = url.into_url().map(move |url| Request::new(method, url));
let req = url.into_url().map(move |url| {
let mut req = Request::new(method, url);
let headers = req.headers_mut();
for (key, value) in &self.inner.headers {
headers.insert(key, value.clone());
}
req
});
RequestBuilder::new(self.clone(), req)
}

Expand Down
23 changes: 22 additions & 1 deletion tests/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@ mod support;

use support::server;

use http::header::{CONTENT_LENGTH, CONTENT_TYPE, TRANSFER_ENCODING};
use http::{
header::{CONTENT_LENGTH, CONTENT_TYPE, TRANSFER_ENCODING},
HeaderMap, HeaderValue,
};
#[cfg(feature = "json")]
use std::collections::HashMap;

Expand Down Expand Up @@ -528,3 +531,21 @@ async fn error_has_url() {
let err = reqwest::get(u).await.unwrap_err();
assert_eq!(err.url().map(AsRef::as_ref), Some(u), "{err:?}");
}

#[test]
fn client_request_builder_includes_default_headers() {
let mut headers = HeaderMap::new();
headers.insert("X-MY-HEADER", HeaderValue::from_static("value"));
let client = Client::builder()
.default_headers(headers)
.build()
.expect("build client");
let req = client
.get("http://google.com")
.build()
.expect("build request");
assert!(req
.headers()
.get("X-MY-HEADER")
.is_some_and(|v| v == HeaderValue::from_static("value")));
}