feat: Add per request compression config #2667
Open
+161
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Merged
seanmonstar
reviewed
May 7, 2025
|
|
||
| /// Get the `gzip` option on this request. | ||
| #[inline] | ||
| pub fn gzip(&self) -> Option<&bool> { |
There was a problem hiding this comment.
This is my gut feeling: for now, there's less need to provide all these getters on the Request type. I would just put the equivalent gzip(bool) functions on the RequestBuilder.
(Hm, with all these possible options, it occurs to me that a user might just want to say no_(de)compression() on either builder, to indicate never use any of the decoders...)
There was a problem hiding this comment.
I would just put the equivalent
gzip(bool)functions on theRequestBuilder.
I'm fine with this change. Let me add those functions to RequestBuilder first and gather some feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the per request compression config like gzip, zstd and so on.
no_gzip/gzipfor Request #2616This PR adds a number of new request-level APIs, all of which follow the same style as the existing ones. We will return
Nonedirectly if the corresponding feature is not enabled, allowing users to callreq.gzip_mut.map(|v| *v = false)to achieve the same effect asno_gzip.I'm open to alternative API designs like
req.no_gzip().