Skip to content

chore: make ci pass #2666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

chore: make ci pass #2666

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ jobs:
cargo update -p tokio --precise 1.29.1
cargo update -p tokio-util --precise 0.7.11
cargo update -p idna_adapter --precise 1.1.0
cargo update -p hashbrown@0.15.2 --precise 0.15.0
Copy link
Contributor

@Xuanwo Xuanwo May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing we don't need to pin hashbrown anymore?

Copy link
Owner

@seanmonstar seanmonstar May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked if it's changed, but this was because 2 versions of hashbrown were depended on by dev-dependencies.

Copy link
Contributor

@Xuanwo Xuanwo May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried another way in #2668 but doesn't work.

Hi @linyihai, would you like to try remove this line directly?

Copy link
Contributor Author

@linyihai linyihai May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd try it in the next commit. 😃

Copy link
Contributor

@Xuanwo Xuanwo May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, it doesn't work. I believe 1b5ed25 is good enough. Thank you @linyihai for this.

cargo update -p hashbrown --precise 0.15.0
cargo update -p native-tls --precise 0.2.13
cargo update -p once_cell --precise 1.20.3

Expand Down
Loading