Skip to content

feat: BBR congestion control for http3 #2642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025
Merged

feat: BBR congestion control for http3 #2642

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6841e3a
feat: BBR congestion control for http3
Apr 14, 2025
450e9a1
Merge branch 'master' into bbr-congestion-control
seanmonstar Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions src/async_impl/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,8 @@ struct Config {
#[cfg(feature = "http3")]
quic_send_window: Option<u64>,
#[cfg(feature = "http3")]
quic_congestion_bbr: bool,
#[cfg(feature = "http3")]
h3_max_field_section_size: Option<u64>,
#[cfg(feature = "http3")]
h3_send_grease: Option<bool>,
Expand Down Expand Up @@ -307,6 +309,8 @@ impl ClientBuilder {
#[cfg(feature = "http3")]
quic_send_window: None,
#[cfg(feature = "http3")]
quic_congestion_bbr: false,
#[cfg(feature = "http3")]
h3_max_field_section_size: None,
#[cfg(feature = "http3")]
h3_send_grease: None,
Expand Down Expand Up @@ -373,6 +377,7 @@ impl ClientBuilder {
quic_stream_receive_window,
quic_receive_window,
quic_send_window,
quic_congestion_bbr,
h3_max_field_section_size,
h3_send_grease,
local_address,
Expand All @@ -397,6 +402,11 @@ impl ClientBuilder {
transport_config.send_window(send_window);
}

if quic_congestion_bbr {
let factory = Arc::new(quinn::congestion::BbrConfig::default());
transport_config.congestion_controller_factory(factory);
}

let mut h3_client_config = H3ClientConfig::default();

if let Some(max_field_section_size) = h3_max_field_section_size {
Expand Down Expand Up @@ -542,6 +552,7 @@ impl ClientBuilder {
config.quic_stream_receive_window,
config.quic_receive_window,
config.quic_send_window,
config.quic_congestion_bbr,
config.h3_max_field_section_size,
config.h3_send_grease,
config.local_address,
Expand Down Expand Up @@ -746,6 +757,7 @@ impl ClientBuilder {
config.quic_stream_receive_window,
config.quic_receive_window,
config.quic_send_window,
config.quic_congestion_bbr,
config.h3_max_field_section_size,
config.h3_send_grease,
config.local_address,
Expand Down Expand Up @@ -2071,6 +2083,20 @@ impl ClientBuilder {
self
}

/// Override the default congestion control algorithm to use [BBR]
///
/// The current default congestion control algorithm is [CUBIC]. This method overrides the
/// default.
///
/// [BBR]: https://datatracker.ietf.org/doc/html/draft-ietf-ccwg-bbr
/// [CUBIC]: https://datatracker.ietf.org/doc/html/rfc8312
#[cfg(feature = "http3")]
#[cfg_attr(docsrs, doc(cfg(all(reqwest_unstable, feature = "http3",))))]
pub fn http3_congestion_bbr(mut self) -> ClientBuilder {
self.config.quic_congestion_bbr = true;
self
}

/// Set the maximum HTTP/3 header size this client is willing to accept.
///
/// See [header size constraints] section of the specification for details.
Expand Down