New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unsound use of pointer::add #185

Merged

seanmonstar merged 1 commit into seanmonstar:master from krasimirgg:fix-uns

Sep 30, 2024

Contributor

krasimirgg commented Sep 25, 2024 •

edited

Loading

No functional changes intended.

From the docs of pointer::add:

If the computed offset is non-zero, then self must be derived from a pointer to some allocated object, and the entire memory range between self and the result must be in bounds of that allocated object. In particular, this range must not “wrap around” the edge of the address space.


          fix unsound pointer arithmetic

47a765f

Owner

seanmonstar commented Sep 25, 2024

Thanks! Notably, this was reported in #177.

Thoughts @AaronO?

seanmonstar approved these changes

View reviewed changes

seanmonstar merged commit cf69365 into seanmonstar:master

41 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet