Ignoring invalid headers for requests #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grnmeira
commented
Aug 5, 2023
| @@ -1,4 +1,4 @@ | |||
| ///! Utility macros | |||
| //! Utility macros | |||
There was a problem hiding this comment.
Not sure why clippy started acting up with this now. The lint was introduced on 1.70 and latest commit is the one enabling clippy for the pipelines.
|
@seanmonstar any chances we could get this in? Happy to make any changes if needed too. |
seanmonstar
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea for this PR came up from this discussion in the hyper repo.
This PR tries to make a request version of the
ParserConfig::ignore_invalid_headers_in_responsesconfiguration, introduced asParserConfig::ignore_invalid_headers_in_requests, so that we can also ignore invalid headers in requests.In order to achieve that avoiding breaking backwards compatibility, it splits the
ParserConfigstruct used forparse_headers_iter_uninitintoParserConfigandHeaderParserConfig.Happy to reassess the tests or the approach.