Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Angular and spin.js #2

Merged
merged 2 commits into from
May 1, 2018
Merged

Update Angular and spin.js #2

merged 2 commits into from
May 1, 2018

Conversation

puku0x
Copy link
Contributor

@puku0x puku0x commented Apr 3, 2018

Hi,

Thank you for your example.
I realized that the sample app showed an erroe like fgnass/spin.js#356 .

After spin.js v3 was released, you can change the code as following.

// [Before]
// spinner.component.ts
declare var Spinner: any;

// .angular-cli.json
"scripts": [
  "../node_modules/spin.js/spin.js"	
],
// [After]
// spinner.component.ts
import { Spinner } from 'spin.js';

// .angular-cli.json
"scripts": [],

Moreover, I updated Angular to v5 and used BehaviorSubject to simplify spinner.service.ts.
Please use my PR if you like it 😃

@seanlmcgill seanlmcgill merged commit f08718b into seanlmcgill:master May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants