Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dbtypes and the private lookup hash maps #47

Closed
seancorfield opened this issue Jul 11, 2019 · 0 comments
Closed

Refactor dbtypes and the private lookup hash maps #47

seancorfield opened this issue Jul 11, 2019 · 0 comments
Milestone
1.0.2

Comments

@seancorfield
Copy link
Owner

Now that :dbname-separator and :host-prefix are a thing, make dbtypes the master structure and build the other lookups from it instead (or look things up directly in dbtypes).
@seancorfield seancorfield added this to the 1.0.2 milestone Jul 11, 2019
seancorfield added a commit that referenced this issue Jul 15, 2019
@seancorfield
Finish off #47
8883167 
Make `dbtypes` public again (oops!). Note that it _won't_ contain defaults (if folks feel they need them, they can easily be added). Use `:host :none` in `dbtypes` to indicate a local database (no `:host`/`:port` segment) which is more consistent with how users would specify a new database.

Reduce the number of special cases in the JDBC URL assembly, now that `:host :none` from `dbtypes` can drive that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.2
Development

No branches or pull requests
1 participant
@seancorfield