Merge pull request #1 from seamuslee001/CRM-19448

Further test fixes
seamuslee001 · Oct 10, 2016 · 4335f07 · 4335f07
2 parents 3cdb86a + fb1c6b2
commit 4335f07
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/CRM/Core/BAO/Note.php b/CRM/Core/BAO/Note.php
@@ -143,7 +143,7 @@ public static function add(&$params, $ids = array()) {
       return CRM_Core_DAO::$_nullObject;
     }
 
-    if ($params['entity_table'] == 'civicrm_contact' && !empty($params['check_permissions'])) {
+    if (!empty($params['entity_table']) && $params['entity_table'] == 'civicrm_contact' && !empty($params['check_permissions'])) {
       if (!CRM_Contact_BAO_Contact_Permission::allow($params['entity_id'], CRM_Core_Permission::EDIT)) {
         throw new CRM_Exception('Permission denied to modify contact record');
       }

diff --git a/CRM/Core/DAO.php b/CRM/Core/DAO.php
@@ -2436,13 +2436,15 @@ public function addSelectWhereClause() {
         $relatedClauses = array();
         $relatedEntities = $this->buildOptions('entity_table', 'get');
         foreach ((array) $relatedEntities as $table => $ent) {
-          $ent = CRM_Core_DAO_AllCoreTables::getBriefName(CRM_Core_DAO_AllCoreTables::getClassForTable($table));
-          $subquery = CRM_Utils_SQL::mergeSubquery($ent);
-          if ($subquery) {
-            $relatedClauses[] = "(entity_table = '$table' AND entity_id " . implode(' AND entity_id ', $subquery) . ")";
-          }
-          else {
-            $relatedClauses[] = "(entity_table = '$table')";
+          if (!empty($ent)) {
+            $ent = CRM_Core_DAO_AllCoreTables::getBriefName(CRM_Core_DAO_AllCoreTables::getClassForTable($table));
+            $subquery = CRM_Utils_SQL::mergeSubquery($ent);
+            if ($subquery) {
+              $relatedClauses[] = "(entity_table = '$table' AND entity_id " . implode(' AND entity_id ', $subquery) . ")";
+            }
+            else {
+              $relatedClauses[] = "(entity_table = '$table')";
+            }
           }
         }
         if ($relatedClauses) {