Force render mismatches style between the server and client #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdnha11
force-pushed
the
fix-gatsby-default-screen-class-issue
branch
from
5de8643
to
fe8ce0d
Compare
hdnha11
force-pushed
the
fix-gatsby-default-screen-class-issue
branch
from
fe8ce0d
to
19fbc0e
Compare
|
This is fixed now like proposed in this PR, but then by applying the two-pass-rendering in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gatsby renders the page without knowing the viewport of the device it displays towards.
We can detect and set
defaultScreenClassconfig on the client-side (https://github.com/sealninja/react-ssr-example/blob/master/client.js), but React expects that the rendered content is identical between the server and the client. It can patch up differences in text content, but not object (https://reactjs.org/docs/react-dom.html#hydrate). Therefore thestylemismatch between the server-side and client-side will not get re-render.One possible solution that I have found is doing a two-pass rendering facebook/react#8017 (comment). Doing so will introduce a
flashingeffect when reloading the page. We can overcome this issue by introducing a small splash screen long enough to load the correct viewport (https://stackoverflow.com/questions/57188179/show-overlay-only-once-on-page-entrance-not-route-change-howto).