This repository has been archived by the owner on Sep 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 47
refactor: make single seal instance deploy stable #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some discussions about etcd vs sqlite.
etcd is not reliable to work with apiserver in a single node, and causes more IO consumption. |
after discussing, keep using etcd as the backend in this PR. etcd stating can operate as below inside the container.
|
gitlawr
reviewed
Apr 24, 2023
Signed-off-by: thxCode <[email protected]>
Signed-off-by: thxCode <[email protected]>
Signed-off-by: thxCode <[email protected]>
Signed-off-by: thxCode <[email protected]>
Signed-off-by: thxCode <[email protected]>
Signed-off-by: thxCode <[email protected]>
gitlawr
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
alexcodelf
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#458
this PR introduces the following changes.
/var/run/seal
, so we can easily launch a single seal container without any data lost bydocker run -d --privileged -v <host path>:/var/run/seal -p 80:80 -p 443:443 sealio/seal-server:main
. @Finenyaco