-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ODroid C4 support #95
Conversation
Adds the ODroid C4 as a valid device. Signed-off-by: Curtis Millar <[email protected]>
reset_cntvoff(); | ||
} | ||
|
||
#if CONFIG_MAX_NUM_NODES > 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is the alias ENABLE_SMP_SUPPORT
that is also in use, is there a policy when to use what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a 2nd look, seems this is only used in the kernel, but not in the ELF loader. So ignore that comment above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think ENABLE_SMP_SUPPORT
is only defined inside the kernel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It used to be, but then the kernel's private config file was moved into libsel4: https://github.com/seL4/seL4/blob/master/libsel4/include/sel4/config.h#L96
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be a thing for later then: #96
Looks good to me, the |
Adds the ODroid C4 as a valid device.