elfloader/risc-v: improve OpenSBI support #117
Conversation
axel-h
force-pushed
the
patch-axel-6
branch
2 times, most recently
from
20daf3d to
b0d9f85
Compare
axel-h
force-pushed
the
patch-axel-6
branch
from
b0d9f85 to
608d24b
Compare
cmake-tool/helpers/rootserver.cmake
Outdated
| # When using OpenSBI, the whole system image (usually consisting | ||
| # of the ELF-Loader, a device tree, the kernel, and a userland) | ||
| # is packaged as an OpenSBI payload. | ||
| file(GLOB_RECURSE deps) |
There was a problem hiding this comment.
What's happening here? deps looks to be unused, and this cmake command isn't given any paths to glob and so deps should end up empty too.
There was a problem hiding this comment.
I've moved the statement back where it was. If this does nothing, we can also remove it completely then.
There was a problem hiding this comment.
Thanks.It looks like it's missing the other parts of it's implementation, actually specifying the path to the opensbi sources and then adding the sources to the depends line of add_custom_command. If you wanted to add a commit to this PR adding ${BBL_PATH} to the end of that statement, and also adding the deps arg to the ${CMAKE_BINARY_DIR}/bbl/bbl custom command then that'd still come under the PR's goal of "improve OpenSBI support". Alternatively you could ignore it, or remove it if you think it's better to assume that the opensbi implementation isn't going to be edited by anyone between builds.
There was a problem hiding this comment.
Can we do this in a separate PR? I will open a dedicated issue for this.
- improve comments and variable names - allow platforms to customize OpenSBI parameters - OPENSBI_PLAT_XLEN - OPENSBI_PLAT_ISA - OPENSBI_PLAT_ABI Signed-off-by: Axel Heider <[email protected]>
axel-h
force-pushed
the
patch-axel-6
branch
from
608d24b to
b27c288
Compare
OPENSBI_PLAT_XLENOPENSBI_PLAT_ISAOPENSBI_PLAT_ABI