Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prove cancelBadgedSends_ccorres #816

Open
wants to merge 1 commit into
base: rt
Choose a base branch
from
Open

Prove cancelBadgedSends_ccorres #816

wants to merge 1 commit into from

Conversation

michaelmcinerney
Copy link
Contributor

@michaelmcinerney michaelmcinerney commented Sep 3, 2024 •
edited
Loading

Test with seL4/seL4#1302

@michaelmcinerney michaelmcinerney self-assigned this Sep 5, 2024
@michaelmcinerney michaelmcinerney added the MCS related to `rt` branch and mixed-criticality systems label Sep 5, 2024
@michaelmcinerney michaelmcinerney marked this pull request as ready for review September 5, 2024 02:15
lsf37
lsf37 approved these changes Sep 8, 2024
View reviewed changes
Copy link
Member

@lsf37 lsf37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I'm quite happy with this, this was one of the functions I thought would be hardest in the whole IPC set.

We should remove the vcg_step by proving an annotation rule for While that can be used with subst and use that before vcg, but otherwise I'm happy for this to go ahead (modulo the small cleanup bits).

Xaphiosis
Xaphiosis approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@Xaphiosis Xaphiosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Still not quite a fan of the function_spec_extra_info, but am outvoted and I guess function_spec2 is a kind of precedent. Don't forget to squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsf37 lsf37 lsf37 approved these changes

@Xaphiosis Xaphiosis Xaphiosis approved these changes

@corlewis corlewis Awaiting requested review from corlewis

Assignees

@michaelmcinerney michaelmcinerney

Labels
MCS related to `rt` branch and mixed-criticality systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelmcinerney @Xaphiosis @lsf37