Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase tutorial-add-remark branch #223

Open
damithc opened this issue Oct 2, 2024 · 3 comments
Open

Rebase tutorial-add-remark branch #223

damithc opened this issue Oct 2, 2024 · 3 comments
Labels
p.High prefer to be fixed in the next few releases

Comments

@damithc
Copy link
Contributor

damithc commented Oct 2, 2024

Update add-remark branch by rebasing, to fix issues mentioned in in nus-cs2103-AY2425S1/forum#460
Need to update https://se-education.org/guides/tutorials/ab3AddRemark.html as well

@damithc damithc added the p.High prefer to be fixed in the next few releases label Oct 2, 2024
@drustanyjt
Copy link

Hi prof @damithc I was trying to look into this, but I'm a little confused about the steps to take. For reference here are the 9 commits on the tutorial-add-remark branch:
image

Would it be correct to say we want to:

  1. rebase tutorial-add-remark to be ahead of master so that we're using the most updated APIs from the rest of AB3 (in particular the Person class utility functions) and have a similar project structure (for the static import statement)
  2. this would lead to some commits having outdated API calls. So for each of the 9 commits we manually update any code without losing the main learning point from each commit
  3. update URLs in the ab3addRemark guide to reference the new commits and if necessary the code blocks that appear in the guide

@damithc
Copy link
Contributor Author

damithc commented Oct 8, 2024

Would it be correct to say we want to:

1. rebase `tutorial-add-remark` to be ahead of `master` so that we're using the most updated APIs from the rest of AB3 (in particular the `Person` class utility functions) and have a similar project structure (for the static import statement)

2. this would lead to some commits having outdated API calls. So for each of the 9 commits we manually update any code without losing the main learning point from each commit

3. update URLs in the ab3addRemark guide to reference the new commits and if necessary the code blocks that appear in the guide

Yes. that's correct @drustanyjt

@drustanyjt
Copy link

Got it, I'll work on a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p.High prefer to be fixed in the next few releases
Projects
None yet
Development

No branches or pull requests

2 participants