Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AB3 add remark command tutorial has outdated commits #460

Open
josh1248 opened this issue Oct 2, 2024 · 3 comments
Open

AB3 add remark command tutorial has outdated commits #460

josh1248 opened this issue Oct 2, 2024 · 3 comments

Comments

@josh1248
Copy link

josh1248 commented Oct 2, 2024

Reference: https://se-education.org/guides/tutorials/ab3AddRemark.html#putting-everything-together

In the referenced tutorial, there are some commits shown which does not tally with the current AB3 version. Here are some I spotted, there may be others I am missing

  1. https://se-education.org/guides/tutorials/ab3AddRemark.html#modify-person-to-support-a-remark-field has outdated commit se-edu/addressbook-level3@ce998c3#diff-e110a8668673196a887d394dedf7ddc46172fb4c28885738fc01fcdf010950db

image

image

toString() method is outdated. Current method uses a util function

  1. https://se-education.org/guides/tutorials/ab3AddRemark.html#make-the-command-accept-parameters has outdated commit se-edu/addressbook-level3@dc6d513#diff-a8e35af8f9c251525063fae36c9852922a7e7195763018eacec60f3a4d87c594

image

project structure has changed somewhat, import statement at line 4 should be updated to import static seedu.address.logic.Messages.MESSAGE_INVALID_COMMAND_FORMAT;

@damithc
Copy link
Contributor

damithc commented Oct 2, 2024

@josh1248 Thanks for reporting this. Yes, the commits in that branch seems to be a bit outdated.
We aim to update it in the next round.

Others, if you spot any more differences, please report here.

Related #442

@yadobler
Copy link

yadobler commented Oct 2, 2024

:lol: I assumed it was intentional so that students won't just copy paste the entire branch and call it a day. (ie it will force students to debug, making it easier to just manually follow the steps and add them one by one)

@damithc
Copy link
Contributor

damithc commented Oct 3, 2024

:lol: I assumed it was intentional so that students won't just copy paste the entire branch and call it a day. (ie it will force students to debug, making it easier to just manually follow the steps and add them one by one)

You know, that's not a bad idea 😁
In fact, we can now catch those who just copied the branch without doing the tutorial properly :-p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants