Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated path with special functions to flag plates and zero pad fieldIDs for relevant run2d version #30

Merged
merged 9 commits into from
Sep 1, 2022

Conversation

Sean-Morrison
Copy link
Contributor

updated path with special functions to flag plates and zero pad fieldIDs for relevant run2d version

Copy link
Collaborator

@havok2063 havok2063 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks ok to me. I suggested some code changes that better conform to python style guides, and improve readability. I also have some questions about the pad_fieldid function, but I'll add those to the tree PR.

Can you add some tests for these, and make sure all the tests pass? You can probably just add your examples to the test_special_function test in tests/paths/test_sdss5.py. This is a test that checks that special functions used in paths return the proper content.

def test_special_function(self, path, name, special, keys, exp):

If you're not familiar with writing tests for python, I can help. Just ping me.

@havok2063 havok2063 merged commit 950538a into main Sep 1, 2022
@havok2063 havok2063 deleted the boss branch June 2, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants