Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Replace broken Homebrew formula #7

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

helpermethod
Copy link
Member

@helpermethod helpermethod commented Jun 18, 2024

This PR replaces the autogenerated Homebrew formula with a manually crafted one.

Major differences to the autogenerated one:

  • it incorporates native extensions depending on the architecture
  • it removes the broken formula
  • it generates var/version and var/version_native files during install

Release automation will be the subject of a future pull request.

@helpermethod
Copy link
Member Author

helpermethod commented Jun 21, 2024

Just noticed that the platform file is missing. Should be easy to fix.

@helpermethod helpermethod force-pushed the bug/replace-broken-homebrew-formula branch from c4c436c to 716217c Compare June 21, 2024 15:53
@helpermethod
Copy link
Member Author

Done. Tested locally and works perfectly.

@helpermethod helpermethod force-pushed the bug/replace-broken-homebrew-formula branch 3 times, most recently from 5859e36 to 8e20e51 Compare June 22, 2024 08:12
@helpermethod helpermethod force-pushed the bug/replace-broken-homebrew-formula branch from 8e20e51 to 34f14b7 Compare June 22, 2024 11:17
@marc0der marc0der merged commit 449d302 into master Jul 29, 2024
@marc0der marc0der deleted the bug/replace-broken-homebrew-formula branch July 29, 2024 07:04
@nguymin4 nguymin4 mentioned this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants