This repository has been archived by the owner on Feb 3, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
Refactor reachmaps #148
Merged
Refactor reachmaps #148
Commits on Feb 13, 2017
-
Add ListPackages case w/slashes in root path
Not covering this basic aspect of how real project roots actually work allowed a windows bug to hide until real data came through - #146.
Configuration menu - View commit details
-
Copy full SHA for 5fcd04e - Browse repository at this point
Copy the full SHA 5fcd04eView commit details -
Remove basedir silliness from wmToReach()
This was never used, because it wasn't actually needed.
Configuration menu - View commit details
-
Copy full SHA for e4bcce7 - Browse repository at this point
Copy the full SHA e4bcce7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96ce383 - Browse repository at this point
Copy the full SHA 96ce383View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b81a45 - Browse repository at this point
Copy the full SHA 7b81a45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 13e24e8 - Browse repository at this point
Copy the full SHA 13e24e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 547776f - Browse repository at this point
Copy the full SHA 547776fView commit details -
Make ExternalReach produce in- and ex-ReachMaps
ExternalReach (to be renamed presently) was producing only a list of the externally reachable packages from the input set. This is the most important requirement, but there's also a need to keep track of which internal packages are (transitively) imported within each project. Without returning an internal reachmap - a list of all internal packages reachable from each other internal package - we end up recording only those packages from projects that were directly imported across project boundaries. Those packages that are only imported by other internal packages are missed.
Configuration menu - View commit details
-
Copy full SHA for 418617b - Browse repository at this point
Copy the full SHA 418617bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ede5b3 - Browse repository at this point
Copy the full SHA 5ede5b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2d896a - Browse repository at this point
Copy the full SHA e2d896aView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa3f0fa - Browse repository at this point
Copy the full SHA fa3f0faView commit details -
Apply new package list to atom before selecting
Fixes a dumb error, but there's still an intermittent problem. Testing failures suggest a random map iteration order issue.
Configuration menu - View commit details
-
Copy full SHA for 53d6949 - Browse repository at this point
Copy the full SHA 53d6949View commit details -
Fix bug in preparation of workmaps
The old logic was a holdover from before a proper depth-first search algorithm was implemented in wmToReach(). It was trying to do a "bit" of the search work before the real algorithm; however, the final else statement was causing some internal imports to be dropped if the referent had already been visited. The bug was intermittent, as it depended on map iteration order. This also solves the secondary problem of inaccurate backpropagation/poisoning in wmToReach itself, as the internal linkage data it's operating on is now reliable.
Configuration menu - View commit details
-
Copy full SHA for 467e8cf - Browse repository at this point
Copy the full SHA 467e8cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 82c3fcb - Browse repository at this point
Copy the full SHA 82c3fcbView commit details -
Encompass both internal and external in ReachMaps
Rather than splitting the data into two separate map return values, this makes ReachMaps' value a struct containing both the internal package import and external import path list information.
Configuration menu - View commit details
-
Copy full SHA for ddc8467 - Browse repository at this point
Copy the full SHA ddc8467View commit details -
s/ListExternalImports/Flatten/
Much better name. Also adds the capability of filtering out stdlib from PackageTree imports, addressing #113.
Configuration menu - View commit details
-
Copy full SHA for 65fd43a - Browse repository at this point
Copy the full SHA 65fd43aView commit details -
Return "error map" from PackageTree.ToReachMap()
This second parameter provides information about why a package was dropped from the ReachMap - either what problem it had itself, or the problem in one of the internal packages it transitively imports.
Configuration menu - View commit details
-
Copy full SHA for 5c020d4 - Browse repository at this point
Copy the full SHA 5c020d4View commit details
Commits on Feb 22, 2017
-
Configuration menu - View commit details
-
Copy full SHA for fc2fbba - Browse repository at this point
Copy the full SHA fc2fbbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4728f02 - Browse repository at this point
Copy the full SHA 4728f02View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.