chore: use pinned npm supplied by node

nodejs/corepack#93 (comment) nodejs/node#50963 (comment) nodejs/node#50963 Signed-off-by: Sebastian Davids <[email protected]>
sdavids · Jan 12, 2024 · 76089b8 · 76089b8
1 parent 2e86b65
commit 76089b8
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 47 deletions.
diff --git a/.github/actions/setup-node-and-install-dependencies/action.yaml b/.github/actions/setup-node-and-install-dependencies/action.yaml
@@ -39,10 +39,6 @@ runs:
         node-version-file: ${{ inputs.node-version-file }}
         cache-dependency-path: ${{ inputs.dependencies-lock-file }}
         cache: npm
-    - name: Enable Corepack
-      shell: bash
-      working-directory: ${{ inputs.working-directory }}
-      run: corepack enable npm
     - name: Install dependencies
       shell: bash
       working-directory: ${{ inputs.working-directory }}

diff --git a/TODO b/TODO
@@ -11,12 +11,6 @@ https://github.com/amilajack/eslint-plugin-compat/issues/603
 +
 https://github.com/azeemba/eslint-plugin-json/issues/80
 
-* use official corepack support from setup-node action
-+
-remove 'Enable Corepack' step in setup-node-and-install-dependencies/action.yaml
-+
-https://github.com/actions/setup-node/issues/531
-
 * remove body-max-line-length in commitlint.config.mjs
 +
 https://github.com/conventional-changelog/commitlint/issues/2112

diff --git a/hp/package-lock.json b/hp/package-lock.json
diff --git a/hp/package.json b/hp/package.json
@@ -50,10 +50,8 @@
     "format": "scripts/format.sh",
     "format:check": "scripts/format-check.sh"
   },
-  "packageManager": "[email protected]",
   "engines": {
-    "node": ">=20.11",
-    "npm": ">=10"
+    "node": ">=20.11"
   },
   "devDependencies": {
     "@commitlint/cli": "18.4.4",