Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a NAM icon instead of the iPlug2 icon #309

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

olilarkin
Copy link
Contributor

icon_256x256@2x

@sdatkinson
Copy link
Owner

Thanks!

IMO (as someone who's not done this before), this is a surprising number of changes. Mind if I ask while we're here how to know all of the things that have to be done in order to change the icon?

I'd love to have a checklist to go on in case we make changes here in the future. Or is there any "secret" to lighten the cognitive load vs looking at the changes here and trying to mimic them move-for-move from the bottom up?

@olilarkin
Copy link
Contributor Author

olilarkin commented Jun 27, 2023

For windows, it's just one file, the .ico. .icns is the old macOS format, which is still used as part of the build scripts. .iconset folder is the new approach for iOS and macOS. On iOS it just requires a 1024x1024 image nowadays, but on macOS, it requires multiple different files. Fortunately, you can use various programs and websites to spit out all of these files from a single input file. Bear in mind, however, that nowadays, the iOS icon gets rounded corners from the OS, where as the other platforms require you to include the rounded corners in the image.

Copy link
Owner

@sdatkinson sdatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@sdatkinson sdatkinson merged commit 604930b into sdatkinson:main Jun 27, 2023
olilarkin added a commit to olilarkin/NeuralAmpModelerPlugin that referenced this pull request Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants