Don't recurse down file directories when collecting files to iterate through

[sdatkinson]

This PR resolves #282 by stopping NAMFileBrowserControl::ScanDirectory() from recusing down subdirectories. The result is also more in line with the experience that I'd like thee to be.

[sdatkinson]

Puzzling me why the macOS build fails...

[sdatkinson]

About the current solution:

I first tried to make ScanDirectory virtual and protected (rather than private) and override it in NAM (least intrusive solution I could think of), but I ran into issues with dirscan.h which defines WDL_DirScan trying to use a strnicmp, which would seem to be right according to the surrounding macros (trying to compile the VST3 on my MBP). But, it failed to compile, suggesting that I use strncmp instead.

that's confusing to me and sort of suggests that the macros' states are somehow different when the compiler visits dirscan.h for IControls.cpp from when it visits while compiling NeuralAmpModelerControls.h (if I #include it at the top). Perhaps delaying the definition of the override in e.g. NeuralAmpModelerControls.cpp would fix it? I tried, and it didn't seem to work.

I'd love to hear from @olilarkin if this rings any bells, though I'm happy to discuss over on iPlug2/iPlug2#979 I'd love for NAM not to impose on iPlug2, it seems to me like the amount of effort to dodge it over here would be considerable. (Though perhaps there's some more advanced C++ I could do to get around it that I'm not thinking of? Again, happy to learn!)

In short, I wanted to get this in shape for final testing so we can release 0.7.4 asap; we can sync up iPlug2 in a tidier way later on. I don't think that it's too much tech debt to resolve, and I really want to get this release out promptly--users are clamoring for the arrows feature 🙂

[olilarkin]

This seems a very brutal way to fix it. I get back from holiday later today and can show you a better way

…

On Mon, 12 Jun 2023 at 02:00, Steven Atkinson ***@***.***> wrote: Merged #289 <#289> into main. — Reply to this email directly, view it on GitHub <#289 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFACLTYSKBBUYOGUJ6SEXDXKZLYPANCNFSM6AAAAAAZCD3FVU> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>