Coroutinize waitpid #2532
Closed
Coroutinize waitpid #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avikivity
reviewed
Nov 10, 2024
src/core/reactor.cc
Outdated
| } | ||
|
|
||
| std::chrono::milliseconds wait_timeout(0); | ||
| for (;;) { |
There was a problem hiding this comment.
Please don't code things as infinite loops, it means the reader has to reverse-engineer the termination condition.
bhalevy
force-pushed
the
coroutinize-waitpid
branch
2 times, most recently
from
b0e2e4f
to
ee292c4
Compare
|
In ee292c4:
|
Commit fb6c969 simplified waitpid by always retrying, even if pidfd_open failed. Coroutinizing this path (and folding do_waitpid back into its only caller: waitpid) simplifies the code even further and consolidate the different do_with allocations into a single coroutine frame. Signed-off-by: Benny Halevy <[email protected]>
No need to define them as static variables. Signed-off-by: Benny Halevy <[email protected]>
bhalevy
force-pushed
the
coroutinize-waitpid
branch
from
ee292c4
to
0bc3ba3
Compare
|
|
@scylladb/seastar-maint please review / consider merging |
dawmd
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit fb6c969 simplified
waitpid by always retrying, even if pidfd_open failed.
Coroutinizing this path (and folding do_waitpid back into
its only caller: waitpid) simplifies the code even further
and consolidate the different do_with allocations into a single
coroutine frame.